[curand] Use host_task rather than codeplay_host_task #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`codeplay_host_task` is deprecated in SYCL 2020, `host_task` should be used instead, this is already what is used by the cublas backend. Additionally support for `codeplay_host_task` was recently removed from DPC++, intel/llvm#4426 so this code wouldn't build with recent DPC++.
mehdi-goli
approved these changes
Oct 20, 2021
mkrainiuk
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codeplay_host_taskis deprecated in SYCL 2020,host_taskshould beused instead, this is already what is used by the cublas backend.
Additionally support for
codeplay_host_taskwas recently removed fromDPC++, intel/llvm#4426 so this code wouldn't
build with recent DPC++.
Here's a log file running the curand tests with this patch:
curand.log