Skip to content

fix: apply stricter typing to the v* signatures #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
broofa merged 4 commits into from
Nov 4, 2024
Merged

fix: apply stricter typing to the v* signatures #831

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccdb102
fix: apply stricter typing to the v4 signature
robbtraister Nov 1, 2024
025a000
fix: allow options to be explicitly passed undefined
robbtraister Nov 1, 2024
f8919a2
fix: apply narrowed typing to all uuid signatures
robbtraister Nov 4, 2024
2e09800
fix: simplify type for v3 and v5
broofa Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v4.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import rng from './rng.js';
import { unsafeStringify } from './stringify.js';

function v4(options?: Version4Options, buf?: undefined, offset?: number): string;
function v4(options?: Version4Options, buf?: Uint8Array, offset?: number): Uint8Array;
function v4(options: Version4Options | undefined, buf: Uint8Array, offset?: number): Uint8Array;
function v4(options?: Version4Options, buf?: Uint8Array, offset?: number): UUIDTypes {
if (native.randomUUID && !buf && !options) {
return native.randomUUID();
Expand Down