ES6 import support?

[Samstiles]

Hey y'all,

Thanks for your work on this lib. Any plans for ES6 import support in the near future? If it's something actively being worked on I'm gonna wait, otherwise I may look into possibly PRing?

EG

import { uuidv1 } from 'node-uuid'

[ZachMayer35]

not quite what your example asks for, but you can already do this:

import {v1 as uuidv1} from 'uuid';

or just

import {v1} from 'uuid';

if you're not picky about the accessor.

[broofa]

As noted in the README, importing uuid is deprecated. Instead, import uuid/<version>. E.g. to import the v1 generator using ES6 notation:

import uuidv1 from 'uuid/v1';

Edit: Recommended incantation is now:

import {v1 as uuidv1} from 'uuid';

[Oliboy50]

@broofa import uuid from 'uuid/v4'; syntax does not work, at least in a Typescript v3 project running on Node v10.9.0 (without webpack nor babel, only ts-node to compile/run Typescript)

I get the following error: TypeError: v4_1.uuid is not a function

on the other hand, import {v4 as uuid} from 'uuid'; works as expected

(tested on uuid v3.3.2)

[broofa]

Apologies for the late response on this. I [still] consider this issue closed, but in light of the "reactions" the above comment has garnered, let me state my position on this...

at least in a Typescript v3 project

... which makes this a Typescript (or TS configuration) issue. This module conforms with the requirements for CommonJS module systems. ES6 syntax should work with packagers that know how to transpile CommonJS modules to ES6.

[Oliboy50]

@broofa actually you're right, in my case this was only due to how Typescript is handling CommonJS/ES6 imports

so, just like many other JS libs like this one, it works this way using TS:

import * as uuid from 'uuid/v4';

console.log(uuid());

here is a codesandbox to play with: https://codesandbox.io/s/5372omm68n

[Sampath-Lokuge]

This too works

import uuid from 'uuid/v4';
const id = uuid();

[jonathanstiansen]

@Sampath-Lokuge that doesn't work in Typescript.

[Sampath-Lokuge]

@jonathanstiansen What was the error? I have used above on Ionic / Typescript app and no issues.

[MartinX3]

Typescript 3.2.4 in angular 7.2.7

Creating an object from this class

import { UUID } from 'uuid/v4';

export class entity {
  id: string;
  name: string;

  constructor() {
    this.id = UUID();
    this.name = '';
  }
}

results in

ERROR TypeError: "Object(...) is not a function"

But switching to
import UUID from 'uuid/v4';
fixed it.

[vladshcherbin]

Should be reopened and fixed.

Rollup is also giving error, with import uuidv4 from 'uuid/v4'. Plugins need to be used to fix it there and this's a single package I met which requires actions from developer to make imports work.

Current index.js with exports is a mess and should be changed to a correct one so we don't need to import from separate files. Package.json file also doesn't reflect needed files.

Es modules support would be also great since it's actually quite easy to add and maintain using modern tools.

@broofa if you are okay with this, PR's can be made to reflect this changes as this package clearly needs some fresh updates to it 😉

[broofa]

Current index.js with exports is a mess

Agreed. Hence the deprecation warning about it going away.

FWIW, the problem with hanging all versions off the top-level module is that it it creates a dependency tree that causes packagers to pull in all 350-600 lines of code in this module, even in the very-common case where you only need the 30-50 lines required to implement v4.

Rollup is also giving error

What's the Rollup team have to say about this?

[vladshcherbin]

@broofa rollup team is pushing forward es modules, for a very long time. To get rid of such cjs errors, a plugin (rollup-plugin-commonjs) should be used there, but with top imports from index.js file it's not needed.

Top level exports from index.js file shouldn't be a problem because tree shaking is used to get only needed dependencies. Rollup and webpack both have it and should remove unused functions from bundle. So, if you only import v4 function, all other functions should be removed.

[broofa]

tree-shaking only works on ES6 modules (according to webpack).