-
Notifications
You must be signed in to change notification settings - Fork 54
Invalid Utf chars #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid Utf chars #339
Changes from 2 commits
ebcfd4f
f67097f
da736cd
8e521ba
c1511c7
72ea444
891be9e
55c99d2
7195031
2d7e4a0
8aeaea3
ff0612c
83e2525
d5499c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -254,7 +254,6 @@ public function testQueryTimeoutUsingStaticTimeout(): void | |
| $this->expectNotToPerformAssertions(); | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * @depends testCreateExistsDelete | ||
| */ | ||
|
|
@@ -1082,6 +1081,43 @@ public function testCreateDocumentDefaults(): void | |
| static::getDatabase()->deleteCollection('defaults'); | ||
| } | ||
|
|
||
| public function testInvalidUtfCharacters(): void | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add some comments about what's being tested through the function?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done 👍
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the exception in this case?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just wanted them to pass, to be aware of this issue, to alert it, and maybe later on add it in Utopia and not in the test
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep I just mean what's the exception message when it does throw?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ohh :) |
||
| { | ||
| $collection = 'null_character'; | ||
|
|
||
| static::getDatabase()->createCollection($collection); | ||
| static::getDatabase()->createAttribute($collection, 'str', Database::VAR_STRING, 128, true); | ||
|
|
||
| $str = "\x00"; | ||
| $this->assertInstanceOf('Utopia\Database\Document', static::getDatabase()->createDocument($collection, new Document([ | ||
| 'str' => $str, | ||
| ]))); | ||
|
|
||
| $str = "\u0000"; | ||
| $this->assertInstanceOf('Utopia\Database\Document', static::getDatabase()->createDocument($collection, new Document([ | ||
| 'str' => $str, | ||
| ]))); | ||
|
|
||
| $str = "\000"; | ||
| $this->assertInstanceOf('Utopia\Database\Document', static::getDatabase()->createDocument($collection, new Document([ | ||
| 'str' => $str, | ||
| ]))); | ||
|
|
||
| $str = "\xE2\x94"; | ||
| try { | ||
| $this->assertInstanceOf('Utopia\Database\Document', static::getDatabase()->createDocument($collection, new Document([ | ||
| 'str' => $str, | ||
| ]))); | ||
| $this->fail('Failed to throw Exception'); | ||
| } catch (Exception $e) { | ||
| $this->assertTrue(true); | ||
| } | ||
|
|
||
| $this->assertInstanceOf('Utopia\Database\Document', static::getDatabase()->createDocument($collection, new Document([ | ||
| 'str' => mb_convert_encoding($str, 'UTF-8', 'UTF-8'), | ||
| ]))); | ||
| } | ||
|
|
||
| /** | ||
| * @throws AuthorizationException|LimitException|DuplicateException|StructureException|Exception|Throwable | ||
| */ | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.