Fix rascal-core using outdated fields & fix source path calculation for compiler mode#2169
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6074 6069 -5
=======================================
Files 741 741
Lines 62224 62258 +34
Branches 9300 9302 +2
=======================================
- Hits 29183 29168 -15
- Misses 30862 30925 +63
+ Partials 2179 2165 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jurgenvinju
left a comment
There was a problem hiding this comment.
This looks good to me. Especially the additions to make compiler mode work were still missing and now they are here. Thanks @DavyLandman
Is PathConfig.listModuleEntries still used anywhere? Perhaps we can clean that up.
|
I'm a bit unsure about the Rascal-lsp special cases. Have we tested those already? |
|
@jurgenvinju and @sungshik I've rewritten the It now has 3 sub-functions:
This has greatly reduced the complexity of the code I think. |
A few fixes for issues found in PathConfig & Rascal compiler while integrating into VS Code.
In the process I've had to rewrite the function, as it was getting to complex to follow.
Note it does not yet implement the design in #2171 but it would be quite simple to do based on this PR (and in some places I already left comments)