Skip to content

Fix rascal-core using outdated fields & fix source path calculation for compiler mode#2169

Merged
DavyLandman merged 13 commits intomainfrom
fix/rascal-core-update-new-pathconfig
Mar 6, 2025
Merged

Fix rascal-core using outdated fields & fix source path calculation for compiler mode#2169
DavyLandman merged 13 commits intomainfrom
fix/rascal-core-update-new-pathconfig

Conversation

@DavyLandman
Copy link
Copy Markdown
Member

@DavyLandman DavyLandman commented Feb 28, 2025

A few fixes for issues found in PathConfig & Rascal compiler while integrating into VS Code.

In the process I've had to rewrite the function, as it was getting to complex to follow.

Note it does not yet implement the design in #2171 but it would be quite simple to do based on this PR (and in some places I already left comments)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 36.00000% with 80 lines in your changes missing coverage. Please review.

Project coverage is 46%. Comparing base (e04a9a7) to head (b58f606).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/PathConfig.java 32% 71 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2169   +/-   ##
=======================================
- Coverage       46%     46%   -1%     
+ Complexity    6074    6069    -5     
=======================================
  Files          741     741           
  Lines        62224   62258   +34     
  Branches      9300    9302    +2     
=======================================
- Hits         29183   29168   -15     
- Misses       30862   30925   +63     
+ Partials      2179    2165   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jurgenvinju jurgenvinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Especially the additions to make compiler mode work were still missing and now they are here. Thanks @DavyLandman

Is PathConfig.listModuleEntries still used anywhere? Perhaps we can clean that up.

@jurgenvinju
Copy link
Copy Markdown
Member

I'm a bit unsure about the Rascal-lsp special cases. Have we tested those already?

@DavyLandman
Copy link
Copy Markdown
Member Author

@jurgenvinju and @sungshik I've rewritten the fromSourceProjectRascalManifest function, since the logic was getting too complex.

It now has 3 sub-functions:

  1. rascal setup
  2. rascal-lsp setup
  3. All other projects

This has greatly reduced the complexity of the code I think.

@DavyLandman DavyLandman merged commit 7aa1b48 into main Mar 6, 2025
7 of 8 checks passed
@DavyLandman DavyLandman deleted the fix/rascal-core-update-new-pathconfig branch March 6, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants