Merged
Conversation
Member
jurgenvinju
commented
Feb 26, 2025
- the root of a file system should be a folder; for the mvn scheme it was both a folder and a file
- simplified the tests accordingly, no more
- finished a true mvn:/// resolver that is not hampered by the limitations of a logical resolver, including proper listing of authorities and a proper ClassLoader factory method
- cleaning up
…as both a folder and a file
…ons of a logical resolver, including proper listing of authorities and a proper ClassLoader factory method
DavyLandman
requested changes
Feb 26, 2025
Member
DavyLandman
left a comment
There was a problem hiding this comment.
Some small remarks, mostly looks like we discussed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2159 +/- ##
=======================================
- Coverage 50% 50% -1%
- Complexity 6578 6585 +7
=======================================
Files 699 699
Lines 60711 60739 +28
Branches 8886 8886
=======================================
+ Hits 30415 30418 +3
- Misses 28047 28062 +15
- Partials 2249 2259 +10 ☔ View full report in Codecov by Sentry. |
DavyLandman
reviewed
Feb 27, 2025
DavyLandman
reviewed
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.