Skip to content

issue 2149 mvn scheme#2159

Merged
jurgenvinju merged 11 commits intomainfrom
issue-2149-mvn-scheme
Feb 27, 2025
Merged

issue 2149 mvn scheme#2159
jurgenvinju merged 11 commits intomainfrom
issue-2149-mvn-scheme

Conversation

@jurgenvinju
Copy link
Copy Markdown
Member

  • the root of a file system should be a folder; for the mvn scheme it was both a folder and a file
  • simplified the tests accordingly, no more
  • finished a true mvn:/// resolver that is not hampered by the limitations of a logical resolver, including proper listing of authorities and a proper ClassLoader factory method
  • cleaning up

@jurgenvinju jurgenvinju marked this pull request as ready for review February 26, 2025 13:16
Copy link
Copy Markdown
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks, mostly looks like we discussed

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 27.84810% with 57 lines in your changes missing coverage. Please review.

Project coverage is 50%. Comparing base (bf583ae) to head (56523de).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...rascalmpl/uri/file/MavenRepositoryURIResolver.java 25% 46 Missing and 2 partials ⚠️
src/org/rascalmpl/library/util/Maven.java 30% 3 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2159   +/-   ##
=======================================
- Coverage       50%     50%   -1%     
- Complexity    6578    6585    +7     
=======================================
  Files          699     699           
  Lines        60711   60739   +28     
  Branches      8886    8886           
=======================================
+ Hits         30415   30418    +3     
- Misses       28047   28062   +15     
- Partials      2249    2259   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jurgenvinju jurgenvinju merged commit 2490ac1 into main Feb 27, 2025
1 check passed
@jurgenvinju jurgenvinju deleted the issue-2149-mvn-scheme branch February 27, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants