Skip to content

Conversation

@ssnukala
Copy link
Contributor

Added conditions to add the JqueryValidation message under the Select2 container. and other conditions for Radio and Checkbox.
The validation message for Select2 were showing up above the field whereas all the input fields were showing below. This fixes that.
The Radio button and Checkbox should also be fine, I have not tested all scenarios for that.

Added conditions to add the JqueryValidation  message under the Select2 container. and other conditions for Radio and Checkbox
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #1205 (59f4d22) into hotfix (5494cd9) will decrease coverage by 2.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             hotfix    #1205      +/-   ##
============================================
- Coverage     70.68%   68.45%   -2.24%     
- Complexity     1985     1987       +2     
============================================
  Files           173      169       -4     
  Lines          6905     6685     -220     
============================================
- Hits           4881     4576     -305     
- Misses         2024     2109      +85     
Impacted Files Coverage Δ
...rinkles/account/src/Database/Models/Permission.php 60.00% <0.00%> (-7.86%) ⬇️
app/sprinkles/core/src/Csrf/SlimCsrfProvider.php 26.92% <0.00%> (-2.71%) ⬇️
app/sprinkles/account/src/Database/Models/User.php 75.00% <0.00%> (-2.40%) ⬇️
...pp/sprinkles/account/src/Twig/AccountExtension.php 77.77% <0.00%> (-2.23%) ⬇️
...rinkles/account/src/Repository/TokenRepository.php 62.06% <0.00%> (-1.87%) ⬇️
app/sprinkles/account/src/Account/Registration.php 74.11% <0.00%> (-1.47%) ⬇️
.../account/src/ServicesProvider/ServicesProvider.php 81.10% <0.00%> (-1.30%) ⬇️
app/sprinkles/core/src/Router.php 72.00% <0.00%> (-1.08%) ⬇️
...es/admin/src/ServicesProvider/ServicesProvider.php 89.47% <0.00%> (-1.01%) ⬇️
...pp/sprinkles/account/src/Rememberme/PDOStorage.php 93.54% <0.00%> (-0.74%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5494cd9...59f4d22. Read the comment docs.

@lcharette lcharette added this to the 5.0.1 milestone Nov 25, 2023
@lcharette lcharette modified the milestones: 5.0.1, 6.0.0 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: References

Development

Successfully merging this pull request may close these issues.

2 participants