Security: SQL injection risk in materialized view management templates#801
Open
tuanaiseo wants to merge 1 commit intouselotus:mainfrom
Open
Conversation
Templates for `DROP MATERIALIZED VIEW`, `ALTER MATERIALIZED VIEW`, and policy creation interpolate `cagg_name` directly into SQL statements. If `cagg_name` is influenced by external input, this enables SQL injection in DDL statements. Affected files: common_query_templates.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Templates for
DROP MATERIALIZED VIEW,ALTER MATERIALIZED VIEW, and policy creation interpolatecagg_namedirectly into SQL statements. Ifcagg_nameis influenced by external input, this enables SQL injection in DDL statements.Severity:
highFile:
backend/metering_billing/aggregation/common_query_templates.pySolution
Treat object names as untrusted. Build statements using safe identifier composition (e.g., psycopg SQL Identifier) and enforce a strict naming allowlist/regex before use.
Changes
backend/metering_billing/aggregation/common_query_templates.py(modified)Testing