Skip to content

Resolve "Finish Type Transitions v1"#724

Merged
mnida merged 6 commits intomainfrom
phase-1-move-types
Mar 21, 2023
Merged

Resolve "Finish Type Transitions v1"#724
mnida merged 6 commits intomainfrom
phase-1-move-types

Conversation

@glamboyosa
Copy link
Copy Markdown
Contributor

@glamboyosa glamboyosa commented Mar 21, 2023 •
edited
Loading

Closes

Closes LOT-676, LOT-677, LOT-678, LOT-679

Description

This PR moves all the types for

  • Customers (Customers, subscriptions, invoices, credits)
  • Plans (View Plans, Plans Details etc)
  • Addons

Acceptance Criteria

  • UI DOES NOT CHANGE.
  • App works as expected.

shouldn't be merged if this criteria isn't met

@linear
Copy link
Copy Markdown

linear Bot commented Mar 21, 2023

LOT-676 Finish Type Transitions v1

@glamboyosa glamboyosa temporarily deployed to Development March 21, 2023 09:20 — with GitHub Actions Inactive
@glamboyosa glamboyosa temporarily deployed to Development March 21, 2023 09:20 — with GitHub Actions Inactive
@linear
Copy link
Copy Markdown

linear Bot commented Mar 21, 2023

LOT-677 Type Transitions for Customers

LOT-678 Type Transitions for Plans

LOT-679 Type Transitions for Addons

@glamboyosa glamboyosa mentioned this pull request Mar 21, 2023
Merged
2 tasks
@mnida
Copy link
Copy Markdown
Collaborator

mnida commented Mar 21, 2023

This one looks good @glamboyosa

@mnida
Copy link
Copy Markdown
Collaborator

mnida commented Mar 21, 2023 •
edited
Loading

Actually i am getting a bug here on customer subscriptions. @glamboyosa

Uncaught ReferenceError: fromUpcoming is not defined at SubscriptionItem (CustomerSubscriptionView.tsx:552:21) at renderWithHooks (react-dom.development.js:16305:18) at mountIndeterminateComponent (react-dom.development.js:20074:13) at beginWork (react-dom.development.js:21587:16) at beginWork$1 (react-dom.development.js:27426:14) at performUnitOfWork (react-dom.development.js:26557:12) at workLoopSync (react-dom.development.js:26466:5) at renderRootSync (react-dom.development.js:26434:7) at recoverFromConcurrentError (react-dom.development.js:25850:20) at performSyncWorkOnRoot (react-dom.development.js:26096:20)

@mnida mnida temporarily deployed to Development March 21, 2023 18:38 — with GitHub Actions Inactive
@mnida mnida temporarily deployed to Development March 21, 2023 18:38 — with GitHub Actions Inactive
@mnida mnida requested review from mnida and removed request for diego-escobedo March 21, 2023 18:38
@glamboyosa glamboyosa temporarily deployed to Development March 21, 2023 19:33 — with GitHub Actions Inactive
@glamboyosa glamboyosa temporarily deployed to Development March 21, 2023 19:33 — with GitHub Actions Inactive
@mnida mnida temporarily deployed to Development March 21, 2023 21:33 — with GitHub Actions Inactive
@mnida mnida temporarily deployed to Development March 21, 2023 21:33 — with GitHub Actions Inactive
@mnida mnida merged commit a657693 into main Mar 21, 2023
@mnida mnida deleted the phase-1-move-types branch March 21, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnida mnida mnida approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glamboyosa @mnida