Skip to content

Resolve "Use new APIs for add, update, cancel methods"#693

Merged
mnida merged 2 commits intomainfrom
LOT-651-use-some-newer-apis
Mar 17, 2023
Merged

Resolve "Use new APIs for add, update, cancel methods"#693
mnida merged 2 commits intomainfrom
LOT-651-use-some-newer-apis

Conversation

@glamboyosa
Copy link
Copy Markdown
Contributor

Closes

Closes LOT-651.

Description

This PR basically adds / uses new functions for

  • attaching an add-on
  • turning off autorenew
  • switching plans

@linear
Copy link
Copy Markdown

linear Bot commented Mar 16, 2023

LOT-651 Use new APIs for add, update, cancel methods

image.png

kept the methods in /api/ because they should be backwards compatible, but wanted to write 405 to deprecate them from frontend so we're not using old code. However, under time pressure had to remove the 405 and still use the old APIs in the frontend. Let's use the new ones and bring back this commented out 405s

api.ts methods to change:

changeSubscriptionPlan →
/app/subscriptions/{subscription_id}/switch_plan/

turnSubscriptionAutoRenewOff →
/app/subscriptions/{subscription_id}/update/

createSubscriptionAddOns →
/app/subscriptions/{subscription_id}/addons/attach/

cancelCreateSubscriptionAddOns →
/app/subscriptions/{subscription_id}/addons/{addon_id}/cancel/

@glamboyosa glamboyosa temporarily deployed to Development March 16, 2023 10:18 — with GitHub Actions Inactive
@glamboyosa glamboyosa temporarily deployed to Development March 16, 2023 10:18 — with GitHub Actions Inactive
@mnida mnida temporarily deployed to Development March 17, 2023 00:48 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@mnida mnida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mnida mnida merged commit 633c9fa into main Mar 17, 2023
@mnida mnida deleted the LOT-651-use-some-newer-apis branch March 17, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants