Refactor: Draft Invoice move to CustomerViewSet#675
Merged
diego-escobedo merged 6 commits intouselotus:aashish/move-draft-invoicefrom Mar 15, 2023
Conversation
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Collaborator
|
After review, merge this into a new branch so tests can run correctly |
diego-escobedo
requested changes
Mar 13, 2023
Collaborator
diego-escobedo
left a comment
diego-escobedo
left a comment
There was a problem hiding this comment.
Need to see the path for draft invoice changed in the draft invoices tests, plus need to get rid of the old method. Additionally, a loom with the working draft invoice functionality (navigating to customer > subscriptions page in the frontend) would be great
| import "./CopytoClipboard.css"; | ||
| import { Tooltip } from "antd"; | ||
| import Prism from "prismjs"; | ||
| // import Prism from "prismjs"; |
Collaborator
There was a problem hiding this comment.
Why was this commented out?
Contributor
Author
There was a problem hiding this comment.
this is throwing me some frontend issue so i decided to comment it out !
| CustomerDeleteResponseSerializer().validate(return_data) | ||
| return Response(return_data, status=status.HTTP_200_OK) | ||
|
|
||
| @extend_schema( |
Collaborator
There was a problem hiding this comment.
Also need to get rid of the other method.
Contributor
Author
There was a problem hiding this comment.
you mean the old draft_invoice?
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
Aashish-Upadhyay-101
had a problem deploying
to
Development
GitHub Actions
Failure
diego-escobedo
added a commit
that referenced
this pull request
Mar 15, 2023
glamboyosa
pushed a commit
that referenced
this pull request
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.