Merged
Conversation
LOT-547 Optimistic UI For Plan Tags
Similar to Plan External Links, feels way to slow to add a tag to a plan at the moment |
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
mnida
requested changes
Feb 27, 2023
Collaborator
mnida
left a comment
mnida
left a comment
There was a problem hiding this comment.
Found a bug related to planId not being found. Check this loom @glamboyosa. https://www.loom.com/share/705d57ba31b64380b7b48478f8e6bd3a
In addition, is this something we can apply on the plandetails page or will it not make much of a difference?
Contributor
Author
|
very little diff. |
Contributor
Author
|
the point was that we were refetching all plans so doing a search & replace makes sense. Individual plan page is pretty chill. |
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
Collaborator
|
Sounds good @glamboyosa |
mnida
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Closes LOT-547
Description
This MR adds optimistic UI. Well, actually it basically does a search and replace on tags instead of a whole HTTP req. making things faster.