Conversation
LOT-566 Bug - Cancel/Add addon modal is glitchy with many plans (more than 10)
### Summary Check slack I think we summarized it a bit in there. I looked into it and I think I made some fixes but i think because we close and open the modal a lot sometimes it flickers and gets overloaded. This is not great detail but more should be provided in the Slack bug report diego made. |
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
glamboyosa
temporarily deployed
to
Development
GitHub Actions
Inactive
mnida
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Closes LOT-566.
Description
This PR fixes the bug in LOT-566 where if you had >=10 plans in the subscription view of a plan, triggering the modal would cause it to flicker.
Testing