-
Notifications
You must be signed in to change notification settings - Fork 9
👌 Do not create target directory upon initializing a collection #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Would it be possible to merge this PR? |
|
Sorry for the late reply. I want to reactivate this. |
|
I rebased this on the new infrastructure PR, let's see whether the CI is green. |
|
Is that the right implementation for the problem? Creating the target directory might make sense for some cases. |
|
Ok nice, now we know all tests are failing. |
|
It has actually been a long time I have looked into this, feel free to fix it if you have time :) |
|
@danwos Do you have an opinion what is the best handling of this? The collection owns the |
Currently, a collection always creates the target directory upon initialization. This leads to the issue that the symlink driver (and also the jinja driver) does not work as expected.
Not creating a target directory upon collection initialization fixes this issue.
Resolves #22