Skip to content

Conversation

@n-burger
Copy link

@n-burger n-burger commented Mar 30, 2023

Currently, a collection always creates the target directory upon initialization. This leads to the issue that the symlink driver (and also the jinja driver) does not work as expected.

Not creating a target directory upon collection initialization fixes this issue.

Resolves #22

@n-burger n-burger closed this Mar 30, 2023
@n-burger n-burger reopened this Mar 30, 2023
@n-burger
Copy link
Author

Would it be possible to merge this PR?

@ubmarco
Copy link
Member

ubmarco commented Oct 23, 2025

Sorry for the late reply. I want to reactivate this.
My current concern is that we have no CI in place to run the tests.
With that I'm happy to merge this. We should do that in another PR.

@ubmarco
Copy link
Member

ubmarco commented Oct 23, 2025

I rebased this on the new infrastructure PR, let's see whether the CI is green.

@ubmarco ubmarco changed the title Do not create target directory upon initializing a collection 👌 Do not create target directory upon initializing a collection Oct 23, 2025
@ubmarco
Copy link
Member

ubmarco commented Oct 23, 2025

Is that the right implementation for the problem? Creating the target directory might make sense for some cases.
Haven't look too much into this until now. I tend to approve it because the test cases are green.
Not sure yet about the test coverage. Would be really good to expand on the tests when new PRs come in.

@ubmarco
Copy link
Member

ubmarco commented Oct 23, 2025

Ok nice, now we know all tests are failing.
@n-burger Are you interested in fixing this? Or someone else?

@nmosim
Copy link

nmosim commented Oct 23, 2025

It has actually been a long time I have looked into this, feel free to fix it if you have time :)

@ubmarco
Copy link
Member

ubmarco commented Oct 24, 2025

@danwos Do you have an opinion what is the best handling of this? The collection owns the target information.
So I would say it should create the directory based on the selected driver. Another option is to have the driver create that directory.
I have to get into the package more to make an educated statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug when using the symlink driver

3 participants