Print panic message to debug buffer#894
Merged
Merged
Conversation
Collaborator
|
@athei Is there anything left before we can stabilize |
Contributor
Author
|
I think it can be stabilized as is. I need to double check whether the weight stuff is sound, though. |
cmichi
approved these changes
Aug 12, 2021
cmichi
left a comment
Collaborator
There was a problem hiding this comment.
We're waiting for the stabilization of seal_debug_message before merging. Code looks good.
Contributor
Author
HCastano
approved these changes
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should print panic messages to the debug buffer when logging is enabled. This will print useful messages to the console and UIs (once they implement it). It looks like this:
Before we consider merging this we must stabilize
seal_debug_message.Depends on: use-ink/cargo-contract#326