Skip to content

Print panic message to debug buffer#894

Merged
HCastano merged 1 commit into
masterfrom
at-panic-message
Aug 16, 2021
Merged

Print panic message to debug buffer#894
HCastano merged 1 commit into
masterfrom
at-panic-message

Conversation

@athei

@athei athei commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

We should print panic messages to the debug buffer when logging is enabled. This will print useful messages to the console and UIs (once they implement it). It looks like this:

panicked at 'encountered error while querying transferred balance: Decode(Error)', /Users/alexander/Developer/parity/ink/crates/lang/src/dispatcher.rs:145:10

Before we consider merging this we must stabilize seal_debug_message.

Depends on: use-ink/cargo-contract#326

@athei
athei requested a review from cmichi August 12, 2021 11:59
@cmichi

cmichi commented Aug 12, 2021

Copy link
Copy Markdown
Collaborator

@athei Is there anything left before we can stabilize seal_debug_message in the contracts pallet? From my POV it seems to be working well, I'm not aware of any issues with it.

@athei

athei commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

I think it can be stabilized as is. I need to double check whether the weight stuff is sound, though.

@cmichi cmichi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're waiting for the stabilization of seal_debug_message before merging. Code looks good.

@athei

athei commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

@HCastano
HCastano merged commit eabb117 into master Aug 16, 2021
@HCastano
HCastano deleted the at-panic-message branch August 16, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants