Use MaxEncodedLen for output buffer size

[ascjones]

Suggestion by @pgherveou.

Use MaxEncodedLen::max_encoded_len() instead of hardcoded sizes for allocating part of the buffer for the data of the return value of a host fn.

This allows the types for AccountId and Hash to be properly configurable, currently they are restricted to a max size of those hardcoded values.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.65%. Comparing base (6bc816b) to head (f281240).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2128      +/-   ##
==========================================
+ Coverage   53.62%   53.65%   +0.02%     
==========================================
  Files         224      224              
  Lines        7053     7053              
  Branches     3117     3117              
==========================================
+ Hits         3782     3784       +2     
+ Misses       3271     3269       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract	Upstream Size (kB)	PR Size (kB)	Diff (kB)	Diff (%)	Change
call-builder-return-value	9.237	9.237	0	0	➖
call-runtime	2.061	2.061	0	0	➖
combined-extension	2.137	2.12	-0.017	-0.795508	📉
conditional-compilation	1.49	1.49	0	0	➖
contract-storage	7.568	7.568	0	0	➖
contract-terminate	1.329	1.329	0	0	➖
contract-transfer	1.689	1.689	0	0	➖
cross-contract-calls	7.73	7.72	-0.01	-0.129366	📉
cross-contract-calls/other-contract	1.583	1.583	0	0	➖
custom-allocator	7.775	7.775	0	0	➖
custom-environment	2.146	2.146	0	0	➖
dns	7.318	7.318	0	0	➖
e2e-call-runtime	1.296	1.296	0	0	➖
e2e-runtime-only-backend	1.881	1.881	0	0	➖
erc1155	14.308	14.308	0	0	➖
erc20	6.918	6.918	0	0	➖
erc721	10.007	10.007	0	0	➖
events	5.258	5.258	0	0	➖
flipper	1.639	1.639	0	0	➖
incrementer	1.504	1.504	0	0	➖
lang-err-integration-tests/call-builder-delegate	2.638	2.638	0	0	➖
lang-err-integration-tests/call-builder	5.567	5.559	-0.008	-0.143704	📉
lang-err-integration-tests/constructors-return-value	1.985	1.985	0	0	➖
lang-err-integration-tests/contract-ref	5.058	5.05	-0.008	-0.158165	📉
lang-err-integration-tests/integration-flipper	1.815	1.815	0	0	➖
lazyvec-integration-test	4.616	4.616	0	0	➖
mapping-integration-tests	7.999	7.999	0	0	➖
mother	12.741	12.741	0	0	➖
multi-contract-caller	6.645	6.633	-0.012	-0.180587	📉
multi-contract-caller/accumulator	1.378	1.378	0	0	➖
multi-contract-caller/adder	1.912	1.912	0	0	➖
multi-contract-caller/subber	1.932	1.932	0	0	➖
multisig	21.821	21.821	0	0	➖
payment-channel	5.659	5.659	0	0	➖
psp22-extension	7.071	7.071	0	0	➖
rand-extension	2.965	2.965	0	0	➖
sr25519-verification	1.142	1.142	0	0	➖
static-buffer	2.536	2.536	0	0	➖
trait-dyn-cross-contract-calls	2.887	2.887	0	0	➖
trait-dyn-cross-contract-calls/contracts/incrementer	1.545	1.545	0	0	➖
trait-erc20	7.294	7.294	0	0	➖
trait-flipper	1.49	1.49	0	0	➖
trait-incrementer	1.614	1.614	0	0	➖
upgradeable-contracts/delegator	3.928	3.928	0	0	➖
upgradeable-contracts/delegator/delegatee	1.609	1.609	0	0	➖
upgradeable-contracts/delegator/delegatee2	1.609	1.609	0	0	➖
upgradeable-contracts/set-code-hash-migration	1.743	1.743	0	0	➖
upgradeable-contracts/set-code-hash-migration/migration	1.45	1.45	0	0	➖
upgradeable-contracts/set-code-hash-migration/updated-incrementer	1.897	1.897	0	0	➖
upgradeable-contracts/set-code-hash	1.743	1.743	0	0	➖
upgradeable-contracts/set-code-hash/updated-incrementer	1.721	1.721	0	0	➖
wildcard-selector	2.846	2.846	0	0	➖

Link to the run | Last update: Tue Feb 27 15:46:29 CET 2024