Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2126 +/- ##
=======================================
Coverage 53.67% 53.67%
=======================================
Files 224 224
Lines 7048 7046 -2
Branches 3118 3117 -1
=======================================
- Hits 3783 3782 -1
+ Misses 3265 3264 -1 ☔ View full report in Codecov by Sentry. |
ascjones
reviewed
Feb 26, 2024
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
What do you think about just making it a const uint instead of the enum?
ascjones
approved these changes
Feb 26, 2024
smiasojed
approved these changes
Feb 26, 2024
peetzweg
reviewed
Feb 27, 2024
|
|
||
| /// Returns the metadata version used by the contract. | ||
| pub fn version(&self) -> &MetadataVersion { | ||
| pub fn version(&self) -> &u64 { |
Contributor
There was a problem hiding this comment.
Will this change result in the version being output as a number?
So {version: 5} instead of {version: '5'}?
Would prefer it as a number instead of string for easier version comparison up and down. 👍
Contributor
Author
There was a problem hiding this comment.
Yes, this changes the string into the integer. All good there
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Tue Feb 27 16:59:26 CET 2024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps ink! metadata version to 5
Description
Since the introduction of Event 2.0 (#1827), and static buffer size in metadata (#1880), we need to increase the ABI metadata version to 5.
Note
This PR temporarily disables e2e on-chain test step in CI until the new version of
cargo-contractincluding newink_metadatacrate is released.Checklist before requesting a review
CHANGELOG.md