Merged
Conversation
ascjones
approved these changes
Sep 8, 2023
CHANGELOG.md
Outdated
|
|
||
| There are also other notable changes: | ||
|
|
||
| - Rework of event definitions. |
Collaborator
There was a problem hiding this comment.
Link to PR here #1827 I know it also below but saves looking.
CHANGELOG.md
Outdated
Comment on lines
+56
to
+57
| - Enable Rust >= `1.70`, update `subxt` and `contract-build` - [#1855](https://github.com/paritytech/ink/pull/1855) | ||
| - Fix unsupported `--ws-port` argument - [#1850](https://github.com/paritytech/ink/pull/1850) |
Collaborator
There was a problem hiding this comment.
Those are also backported as part of the 4.3.0 #1884 mentioned below. Although manual backports for the most part, so can still mention here I guess.
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
=======================================
Coverage 53.02% 53.02%
=======================================
Files 219 219
Lines 6837 6837
=======================================
Hits 3625 3625
Misses 3212 3212 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the release I had to modify cargo files of
ink_env,ink_macroandink_storagecrates, specifically replacinginkworkspace dependency with a path one.It turns out that using workspace dependencies breaks the publishing process (see rust-lang/cargo#1169).
It was unfortunate that this only appeared when half of the crates have already been published, so I had to quickly patch the fixes in the release branch.