Added missed WhereClosure for the generics into storage_item#1536
Merged
ascjones merged 1 commit intouse-ink:masterfrom Jan 3, 2023
Merged
Added missed WhereClosure for the generics into storage_item#1536ascjones merged 1 commit intouse-ink:masterfrom
WhereClosure for the generics into storage_item#1536ascjones merged 1 commit intouse-ink:masterfrom
Conversation
HCastano
reviewed
Dec 16, 2022
Contributor
HCastano
left a comment
HCastano
left a comment
There was a problem hiding this comment.
Do you have a contract which shows what the problem is/was?
If I'd be inclined to add it as a UI test
HCastano
changed the title
WhereClosure for the generics into storage_itemWhereClosure for the generics into storage_item
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
==========================================
- Coverage 71.62% 71.58% -0.05%
==========================================
Files 205 205
Lines 6295 6295
==========================================
- Hits 4509 4506 -3
- Misses 1786 1789 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Previously it was not possible=) |
ascjones
approved these changes
Jan 3, 2023
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM, the doc tests are good enough to prove this works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missed
WhereClosurefor the generics. Tested this case via documentation