Use workspace inheritance feature for common fields#1413
Use workspace inheritance feature for common fields#1413
Conversation
This lets us use the new workspace inheritance feature
|
Right now this is failing during the linting step of the example contract build due to an I noticed that pub fn with_dylint(&mut self) -> Result<&mut Self> {
let ink_dylint = {
let mut map = value::Table::new();
map.insert("git".into(), "https://github.com/paritytech/ink/".into());
map.insert("tag".into(), "v4.0.0-alpha.3".into());
map.insert("pattern".into(), "linting/".into());
value::Value::Table(map)
};
...The release is still using an old toolchain file which points to In order to work around this I've patched map.insert("branch".into(), "hc-workspace-inheritance".into());However, when trying to use that patched @ascjones, @athei do you guys have any idea about what's going wrong here? |
|
@HCastano lmk when this is ready for review again |
This is a feature that was added in Rust 1.64.0
and allows us to reduce a bit of duplication that exists across our crates.
We may also want to do this for the
examples, but we should sort out #1410 first.Ah, looks like the Rust version in the CI isn't up to date yet 😆I've also updated the nightly version used by the
dylintstep in order to have the workspace inheritancefeature enabled.