Replace default off-chain engine with experimental one, remove old one#1144
Replace default off-chain engine with experimental one, remove old one#1144
Conversation
cmichi
requested review from
a team,
HCastano,
Robbepop and
ascjones
as code owners
cmichi
force-pushed
the
cmichi-remove-old-off-chain-testing-env
branch
from
7771516 to
e5bf08c
Compare
cmichi
force-pushed
the
cmichi-remove-old-off-chain-testing-env
branch
from
e5bf08c to
3dfc2c1
Compare
athei
left a comment
athei
left a comment
There was a problem hiding this comment.
I agree. I think it is fine that it only supports the default env. The testing environment isn't a 100% match with the on chain environment anyways.
❤️ |
HCastano
left a comment
HCastano
left a comment
There was a problem hiding this comment.
Two small questions. Once the CI is fixed it should be good to go
|
|
||
| /// Returns the underlying `u32` representation. | ||
| #[cfg(not(feature = "ink-experimental-engine"))] | ||
| #[cfg(not(feature = "std"))] |
There was a problem hiding this comment.
Why does this need to be behind a feature flag?
There was a problem hiding this comment.
In std the function is never used, clippy fails in std otherwise.
examples/erc20/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| struct PrefixedValue<'a, 'b, T> { |
There was a problem hiding this comment.
It's used calculate the event topic hash, I've added a comment from trait-erc20 which uses the same structure.
Yeah, I'm also not happy with that and the way the tests are currently structured. Maybe we can do some broader refactoring as follow-ups.
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Wed Mar 2 07:56:03 CET 2022 |
|
Why |
5 participants
Follow-up to #1143.
The experimental off-chain env is currently limited in that it only supports
ink_env::DefaultEnvironment, but IMHO the situation of us currently having two off-chain testing engines in every examples is worse.