Merged
Conversation
deuszx
reviewed
Dec 4, 2023
| Ok(exec_result) => { | ||
| let address = exec_result.account_id.clone(); | ||
| self.deploy_returns.push(address.clone()); | ||
| self.record.push_deploy_return(address.clone()); |
Contributor
Author
There was a problem hiding this comment.
nope, we are relying on the trait bounds from frame_system which do not impose Copy
deuszx
approved these changes
Dec 4, 2023
Collaborator
deuszx
left a comment
deuszx
left a comment
There was a problem hiding this comment.
Code around event/result decoding is so similar to what there is in the ink-wrapper <-> drink! integration that it makes me wonder whether we're not taking it a bit too far on either side (drink! or ink-wrapper) and start duplicating the work.
piotrMocz
approved these changes
Dec 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing Treasury Proposal Roadmap - ink!DevHub 1.0 (view)
In order to simplify a bit
Sessionobject, we introduceRecordtype that collects all the results, returns and events that have been produced by contract interactions during a session.