Skip to content

Storage deposit limit#170

Closed
kwingram25 wants to merge 6 commits intomasterfrom
storage-deposit-limit
Closed

Storage deposit limit#170
kwingram25 wants to merge 6 commits intomasterfrom
storage-deposit-limit

Conversation

@kwingram25
Copy link
Copy Markdown
Contributor

@kwingram25 kwingram25 commented Dec 9, 2021

Closes #168

Add storage deposit limit to api call and instantiate interface

@kwingram25 kwingram25 marked this pull request as ready for review December 16, 2021 02:50
@statictype
Copy link
Copy Markdown
Contributor

storage deposit limit is necessary also for calling, not just instantiation

@statictype
Copy link
Copy Markdown
Contributor

statictype commented Dec 17, 2021

the changes to endowment should also be included in this PR:

  • rename to "value"
  • don't show the field if the constructor is not payable
  • atm the constructor is not payable only if the abi attribute isPayable === false. undefined means payable
  • 0 is an acceptable value now

check the apps PR comments for more context polkadot-js/apps#6657

@kwingram25 kwingram25 closed this Feb 4, 2022
@statictype statictype deleted the storage-deposit-limit branch June 28, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add storage_deposit_limit and rename endowment to value

2 participants