Merged
Conversation
ascjones
reviewed
Feb 1, 2023
Co-authored-by: Andrew Jones <[email protected]>
ascjones
approved these changes
Feb 1, 2023
Collaborator
There was a problem hiding this comment.
Okay, I think we should:
- Release the
contract-buildcrate from here - Update
ink_e2eto use this in use-ink/ink#1637 - Wait for
inkv4.0.0-rcto be released - Update
inkdependencies in this PR - Release and merge this PR
Because:
ink_e2e->contract-buildcontract-transcode->ink_env+ink_metadata
sergejparity
approved these changes
Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second release candidate:
Changes
LangError#919subxtto0.26#924I have to manually update ink! version in
Cargo.lockandCargo.tomlbecause it's release depends on this one.