Conversation
HCastano
force-pushed
the
hc-add-verify-command
branch
from
a8633f5 to
a4aabd4
Compare
HCastano
force-pushed
the
hc-add-verify-command
branch
3 times, most recently
from
bf18ec4 to
23a5d82
Compare
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
Possibly a job for a follow up, but it would be really nice to enhance this by querying a node for the contract code deployed at an account and comparing it with the built contract.
| found at {}.", | ||
| format!("`{}`", metadata.contract.name).bright_white(), | ||
| format!("{:?}", manifest_path.as_ref()).bright_white()).bright_red() | ||
| ); |
There was a problem hiding this comment.
It would be super useful to print out the SourceCompiler properties of both reference_wasm and built_wasm in case of non matching wasm.
It's useful to know whether they are the same or different for figuring out why verification failed.
And while we are at it, any other properties we have available in Source e.g. SourceLanguage to catch different versions of ink!.
| let fs_wasm = std::fs::read(built_wasm_path)?; | ||
| let built_wasm = SourceWasm::new(fs_wasm); | ||
|
|
||
| if reference_wasm != built_wasm { |
There was a problem hiding this comment.
I believe we should also compare the contract ABI metadata itself? They should be identical too, and if not it might give clues as to what (if anything) is different.
| } else { | ||
| anyhow::bail!( | ||
| "\nThe metadata for the reference contract does not contain a Wasm binary,\n\ | ||
| therefore we are unable to verify the contract." |
There was a problem hiding this comment.
In this case couldn't we just grab the code hash and then compare that?
HCastano
force-pushed
the
hc-add-verify-command
branch
from
23a5d82 to
67e4cc2
Compare
This should maybe be a warning instead of an error, but I'll need to experiment with this more.
HCastano
force-pushed
the
hc-add-verify-command
branch
from
67e4cc2 to
d6db73f
Compare
Since releases of `cargo-contract` are now bundled with a `wasm-opt` library we can assume that equal versions of `cargo-contract` contain equal versions of `wasm-opt`.
|
Closing in favour of #1306 |
3 participants
Will close the
verifysubcommand part of #525.Note that this command does not necessarily work across different operating systems
or CPU architectures (see the discussion in #525 for more details). As such it should
only be used in the context of a well known Docker container à la
srtool.Current built on top of #680 since I want to make sure that we have all the correct info
in the metadata.