Merged
Conversation
ascjones
approved these changes
Jul 9, 2021
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM, good to go once ink! is released
HCastano
reviewed
Jul 13, 2021
HCastano
approved these changes
Jul 14, 2021
Contributor
HCastano
left a comment
HCastano
left a comment
There was a problem hiding this comment.
Looks good!
Now we just need rc4 to be pushed so the CI can pass
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #284.
Kinda blocked until we have a release of ink!
3.0.0-rc4, since theink_env/ink-debugfeature is newer than the currently released3.0.0-rc3. The tests are failing because they use the published ink! crates.This PR adds a new CLI flag
--release, which mirrors the behavior ofcargo‒ compiling the artifact in release mode is not done by default.