Skip to content

Support optimization-passes in the release profile#231

Merged
ascjones merged 11 commits intomasterfrom
cmichi-use-optimization-flag-from-profile
Mar 24, 2021
Merged

Support optimization-passes in the release profile#231
ascjones merged 11 commits intomasterfrom
cmichi-use-optimization-flag-from-profile

Conversation

@cmichi
Copy link
Copy Markdown
Collaborator

@cmichi cmichi commented Mar 23, 2021

Final piece for closing #169.

@cmichi cmichi requested a review from ascjones March 23, 2021 12:26
@cmichi cmichi removed the request for review from ascjones March 23, 2021 12:56
@cmichi cmichi marked this pull request as draft March 23, 2021 12:56
@cmichi cmichi marked this pull request as ready for review March 23, 2021 13:37
@cmichi cmichi requested a review from ascjones March 23, 2021 13:37
Copy link
Copy Markdown
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is adding a custom key to a cargo profile the correct way to do it? Should we add our own e.g. cargo-contract custom section for this?

Copy link
Copy Markdown
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit 3454c12 into master Mar 24, 2021
@ascjones ascjones deleted the cmichi-use-optimization-flag-from-profile branch March 24, 2021 10:16
@cmichi cmichi mentioned this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants