Skip to content

Conversation

@Name-Alin
Copy link

Add support for referencing flag types in documentation #12

@Name-Alin Name-Alin requested a review from a team as a code owner August 25, 2025 06:46
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think you need to run go mod tidy to update go.sum

@Juneezee Juneezee requested a review from dearchap August 26, 2025 09:09
@iPlessmann
Copy link

Hello all,

Any blockers on this PR? @Juneezee @dearchap

@abitrolly
Copy link
Contributor

Is this a user facing feature?

How to test it with my projects?

@Name-Alin
Copy link
Author

To test it you just need to have a command that has at least one flag available and generate the docs for it using the tabular template. In the generated table the column for "type" should be available

@abitrolly
Copy link
Contributor

I have no idea how to generate docs for urfave/cli command using tabular template.

@Name-Alin
Copy link
Author

You just have to use ToTabularMarkdown function. Check examples in docs_test.go

@Name-Alin
Copy link
Author

Hey @dearchap, sorry to bother you but can you please review this PR? It is only 2 lines change and updated tests...

@Juneezee
Copy link
Member

@dearchap I think #6 updated the CI matrix and broke the required status check in the branch protection rules. I don’t have admin permissions for this repository, so could you update the required status check with the new name in the branch protection rule? Thanks!

@Name-Alin
Copy link
Author

Hey @dearchap, kind reminder, can you please take care of the comment above?

@dearchap dearchap merged commit 21e00b6 into urfave:main Sep 24, 2025
6 checks passed
@Juneezee Juneezee linked an issue Sep 26, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for referencing flag types in documentation

5 participants