Skip to content

Conversation

@pwnslinger
Copy link

This closes issue uqfoundation/multiprocess#64

included __reduce__ for the following objects:

  • _thread._local
  • sqlalchemy.cprocessors.UnicodeResultProcessor
  • psycopg2.extensions.connection
  • psycopg2.extensions.cursor

@mmckerns
Copy link
Member

You are adding dependencies of sqlalchemy and psychopg to dill -- don't add new dependencies. Please split this issue into two PRs. One for the _thread object and anything else in STL, and one for 3rd party objects.

@pwnslinger
Copy link
Author

Sure. I will go for it.

@pwnslinger
Copy link
Author

It's been over 2 weeks passed and I haven't seen any comment on this #PR.

@mmckerns
Copy link
Member

mmckerns commented Sep 17, 2019

I wasn't reviewing this PR as the CI checks are failing... but, generally, the changes look good, I'll review once the CI checks pass.

Also please rename the PR to something more descriptive of the content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants