builder/docker: Use -a option when pushing #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlevesy
changed the title
tgallice
approved these changes
Feb 11, 2021
jlevesy
force-pushed
the
jl/use-push-a
branch
from
b019865 to
4be8bf1
Compare
Docker 20.04 introduced a breaking change docker/cli#2220 that only pushes :latest when docker push is run without an explicit tag. To solve this issue, we now pass the "-a" option, which pushes all images
jlevesy
force-pushed
the
jl/use-push-a
branch
from
4be8bf1 to
8292973
Compare
jlevesy
changed the title
Sypheos
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR makes ubuild passing explicitely the
-aflag to push all known images when callingdocker push.Indeed, Docker 20.04 introduced a breaking change that only pushes
:latestwhen docker push is run without an explicit tag.And this brand new version comes with
Ubuntu 20.04which starts to rollout progressively on github actions.