Fix potential generator exhaustion bug in model loading file detection #3167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This resolves PR #2334
Problem
In the current code, the
filesvariable is created as a generator expression:Generators can only be consumed once. After iteration, they become empty. While the current code works fine (since
sum()only consumes the generator once), this creates a fragile situation that could lead to bugs if future modifications use thefilesvariable multiple times.Example of potential issue
Solution
Convert the generator expression to a list immediately:
This change:
Testing
The change maintains identical behavior to the current implementation but makes the code more maintainable and less error-prone.