Skip to content

Conversation

@mmathew23
Copy link
Collaborator

log is not defined in torch inductor so remove it
move min_sms in is_big_gpu inside DEVICE_TYPE if else

this allows GRPOTrainer to run when trainer.train is called.

verification: https://colab.research.google.com/drive/1uZFEjWRYp3Wxjux1u2jEOjBp6Ec9owtH?usp=sharing

@mmathew23
Copy link
Collaborator Author

mmathew23 commented Jun 23, 2025

Apologies this is for the intel 5/n commit. my feature branch title is wrong

@mmathew23 mmathew23 changed the title intel 6/N fix patch intel 5/N fix patch Jun 23, 2025
log is not defined in torch inductor so remove

Remove log.warning entirely
Copy link
Collaborator

@Datta0 Datta0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielhanchen danielhanchen merged commit 12a05c2 into unslothai:main Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants