Fix AttributeError in GRPO trainer for models without llm attribute #2780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandtannous
force-pushed
the
fix/gemma3-grpo-self-llm
branch
from
7b48a01 to
88b2a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed crash in UNSLOTH_GRPO_TRAINER when using models like Gemma3 that don't inherit FastLlama's from_pretrained method. Added attribute check before accessing self.llm to prevent AttributeError when sleep mode wake-up is attempted on models without vllm engine attributes.
Resolves: Gemma3-1b GRPO notebook AttributeError - "Gemma3ForCausalLM object has no attribute self.llm"
works in tandem with unsloth PR#174