Skip to content

Refactor loss handling in gemma.py #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor loss handling in gemma.py #156

wants to merge 1 commit into from

Conversation

@AshAnand34
Copy link
Contributor

@AshAnand34 AshAnand34 commented May 30, 2025

Related issue: #155

Changes made:

  • Removed redundant label checks and associated comments.
  • Updated loss assignment to use getattr for safer access to outputs.loss.
  • Streamlined logits computation by directly using outputs.logits.

@danielhanchen
Copy link
Contributor

danielhanchen commented Jun 1, 2025

Nice catch on Gemma - I'm actually refactoring it in the automatic compiler since its not just Gemma which broke, but other VLMs

@rolandtannous rolandtannous mentioned this pull request Jun 21, 2025
Merged
@rolandtannous
Copy link
Collaborator

rolandtannous commented Jul 1, 2025

Hello @AshAnand34

Fixes for gemma3 issues have been pushed and merged in #179
Will close this for now.
We appreciate your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AshAnand34 @danielhanchen @rolandtannous