-
-
Notifications
You must be signed in to change notification settings - Fork 942
feat(eslint): enhance unoFunctions option with nested object expressions
#4852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed object expressions
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
unoFunctions option with nested object expressionsunoFunctions option with nested object expressions
antfu
approved these changes
Aug 6, 2025
This was referenced Aug 22, 2025
This was referenced Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
@unocss/orderESLint rule to properly handle nested object expressions in custom functions likecvaandtv, ensuring UnoCSS class ordering is correctly applied throughout complex component variant structures.🐛 Problem
The
@unocss/orderESLint rule was not properly traversing and ordering UnoCSS classes within nested object expressions used by popular variant libraries like class-variance-authority (cva) and tailwind-variants (tv). TheunoFunctionsoption only worked with functions accepting simple string parameters, which worked perfectly with utility functions likeclsxandcx:However, it failed to traverse and process functions with nested object expressions like
cvaandtv, resulting in inconsistent class ordering in component variant definitions where classes within nested objects remained unprocessed.✨ Changes
This enhancement introduces intelligent object traversal capabilities to the
@unocss/orderrule, enabling it to recursively process nested object expressions within function calls.Before
After