fix: generate stub types of with explicit extension import if pkg type is module#371
Merged
fix: generate stub types of with explicit extension import if pkg type is module#371
module#371Conversation
yshrsmz
force-pushed
the
esm-dts
branch
2 times, most recently
from
0609982 to
f2f94ed
Compare
Contributor
Author
|
@pi0 Hi, sorry to bother you, but could you take a look at this PR? |
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 26, 2024
…p to `start` - Make dev and start build instead of stubbing :( Ref: unjs/unbuild#371 - Add link to `lit-task-auto-top-up` task def package - Scaffolding for auto top-up task
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 26, 2024
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
…p to `start` - Make dev and start build instead of stubbing :( Ref: unjs/unbuild#371 - Add link to `lit-task-auto-top-up` task def package - Scaffolding for auto top-up task
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
…p to `start` - Make dev and start build instead of stubbing :( Ref: unjs/unbuild#371 - Add link to `lit-task-auto-top-up` task def package - Scaffolding for auto top-up task
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
…p to `start` - Make dev and start build instead of stubbing :( Ref: unjs/unbuild#371 - Add link to `lit-task-auto-top-up` task def package - Scaffolding for auto top-up task
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
…to `start` - Make dev and start build instead of stubbing :( Ref: unjs/unbuild#371 - Add link to `lit-task-auto-top-up` task def package - Scaffolding for auto top-up task
MaximusHaximus
added a commit
to LIT-Protocol/lit-scheduled-tasks
that referenced
this pull request
Mar 27, 2024
pi0
changed the title
module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolve #370
❓ Type of change
📚 Description
Updated DTS stub generation logic to check its module format so that it can work with ESM package.
I wanted to write test cases for this change, but there seems to be no stub-mode related tests and no idea how to write it 🤔
📝 Checklist