-
Notifications
You must be signed in to change notification settings - Fork 47
Add no_std + alloc support #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Manishearth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please do these as separate commits?
Cargo.toml
Outdated
|
|
||
| [features] | ||
| default = ["std"] | ||
| std = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline at eof please
|
Separated to multiple commits, and added the missing newline |
Manishearth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mod tables should have a #[rustfmt::skip], it's autogenerated and i'd prefer to have it be easily diffable
|
Added relevant |
|
No, please add it to the entire module, that file is generated and should not be manually edited. Please add it to the |
5c3d0eb to
0c85b51
Compare
|
Done. I edited both the script and The travis check seems to fail because of a network timeout when installing Rust. |
|
There is still rustfmt::skip on individual items in |
|
Fixed |
Manishearth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks for patience. Please close issue #15 as this fixes it. |
This pull request adds
no_std+allocsupport behind a feature flag, closing issue #15. It also updates tinyvec dependency, migrates code to 2018 edition of Rust and runsrustfmton the codebase. Tests for both std and no_std versions are added to.travis.yml.