Skip to content

issue 163 fix ULocale < and > operator order #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

issue 163 fix ULocale < and > operator order #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inflection/src/inflection/util/ULocale.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,13 +243,13 @@ inflection::util::ULocale::operator!=(const ::inflection::util::ULocale& other)
inline bool
inflection::util::ULocale::operator<(const ::inflection::util::ULocale& other) const
{
return other.fullName < fullName;
return fullName < other.fullName;
}

inline bool
inflection::util::ULocale::operator>(const ::inflection::util::ULocale& other) const
{
return other.fullName > fullName;
return fullName > other.fullName;
}

inline ::std::string_view
Expand Down
9 changes: 6 additions & 3 deletions inflection/test/src/inflection/util/LocaleUtilsTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,18 @@ TEST_CASE("LocaleUtilsTest#hashTest")
{
inflection::util::ULocale locale1 = inflection::util::LocaleUtils::ARABIC();
inflection::util::ULocale locale2 = inflection::util::LocaleUtils::GERMAN();
inflection::util::ULocale locale3 = inflection::util::LocaleUtils::HINDI();

std::set<inflection::util::ULocale> s;
s.insert(locale1);
s.insert(locale2);
s.insert(locale1);
s.insert(locale3);

auto it = s.begin();

REQUIRE(locale2 == *it);
REQUIRE(locale1 == *(++it));
REQUIRE(locale1 == *it);
REQUIRE(locale2 == *(++it));
REQUIRE(locale3 == *(++it));
}

TEST_CASE("LocaleUtilsTest#testCoverage")
Expand Down
Loading