Duration parsing only supports 9 fractional digits

[Manishearth]

No description provided.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

[nekevss]

Is there a reason for this to be on the ixdtf side vs. temporal_rs?

I think there was a decision at one point to have this fraction handling on temporal_rs so ixdtf wasn't constrained by too much temporal_rs specific support. I can't recall if it was duration specific though, and if this is meant to be an early error, then we should add it back in.

[sffc]

I can't find evidence that ISO-8601 or RFC 9557 or RFC 3339 allow sub-minute offsets in this location. But apparently Temporal requires nanosecond precision.

Note: My comment is based on Manish's link which goes to a section about UTC offset parsing.

[Manishearth]

I don't have a reason, no, though I'm not 100% sure where it should go in temporal_rs

[Manishearth]

Closed in favor of boa-dev/temporal#425

Though I'm noting that Fraction has an as_nanoseconds() method which doesn't quite make sense since you can have fractional minutes or hours.