Skip to content

#40 Rename request id to state id, secure state id#43

Open
martti007 wants to merge 2 commits intomainfrom
issue-40
Open

#40 Rename request id to state id, secure state id#43
martti007 wants to merge 2 commits intomainfrom
issue-40

Conversation

@martti007
Copy link
Contributor

  • Changed certification request structure.
  • Request signature is now calculated from H(CBOR([source state hash, transaction hash]))
  • Changed Request ID name to State ID
  • State Id can now be calculated from certification request

@martti007 martti007 requested review from MastaP and Copilot December 1, 2025 21:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the certification system by renaming "Request ID" to "State ID" and restructuring how certification requests are signed. The signature is now calculated from H(CBOR([source state hash, transaction hash])) instead of the previous approach, and the State ID can now be derived from the certification request itself.

Key Changes:

  • Renamed RequestId class to StateId with updated calculation logic
  • Replaced Authenticator and LeafValue classes with new CertificationData class
  • Updated certification request/response structure with new CertificationRequest, CertificationResponse, and CertificationStatus classes
  • Modified InclusionProof to use CertificationData instead of separate authenticator and transaction hash fields

Reviewed changes

Copilot reviewed 61 out of 61 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
StateId.java New file implementing State ID with updated calculation using CBOR encoding
CertificationData.java New file replacing Authenticator, containing certification information and signature
CertificationRequest.java New request structure for certification submissions
CertificationResponse.java New response structure with optional receipt support
CertificationStatus.java New enum with expanded status codes for certification outcomes
InclusionProof.java Updated to use CertificationData and verify method signature changes
Commitment.java Refactored to use CertificationData instead of RequestId and Authenticator
AggregatorClient.java Updated interface methods to use new certification structures
Multiple test files Updated tests to use new StateId and CertificationData classes
README.md Updated documentation with new class names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MastaP MastaP requested review from lploom and removed request for MastaP January 19, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants