Skip to content

Update ConfigEditor for render strategies + editing language#36

Merged
amoghbanta merged 1 commit intomainfrom
feat/update-config-render-strategies
Feb 13, 2026
Merged

Update ConfigEditor for render strategies + editing language#36
amoghbanta merged 1 commit intomainfrom
feat/update-config-render-strategies

Conversation

@amoghbanta
Copy link
Collaborator

Summary

  • Removed broken web_rendering.model and max_retries inputs (config key no longer exists after pipeline team's render strategies refactor)
  • Added editable default_render_strategy input with placeholder from active config
  • Added read-only render strategy summary showing available strategies with type badges (e.g. two_column [template], llm [llm])
  • Made editing_language editable (was read-only display)
  • Preserved render_strategies, section_render_strategies, default_render_strategy, and translation on save in both ConfigEditor and StoryboardSettingsSheet

Test plan

  • pnpm typecheck passes
  • pnpm test passes (330 tests)
  • Open a book → Config tab → verify no "Web Rendering" input or "Max Retries" field
  • Config tab shows editable "Editing Language" input with placeholder from global config
  • Config tab shows editable "Default Render Strategy" input
  • Config tab shows read-only render strategy summary with type badges
  • Save config → book config.yaml gets editing_language and/or default_render_strategy if set
  • Save config → existing render_strategies, section_render_strategies, translation preserved
  • Storyboard settings save → preserves new config fields, no longer writes web_rendering

…ting_language

The pipeline team replaced `web_rendering: StepConfig` with a render
strategies system. Update ConfigEditor and StoryboardSettingsSheet to
match:

- Remove broken web_rendering.model and max_retries inputs
- Add editable default_render_strategy input with placeholder from active config
- Show read-only render strategy summary with type badges
- Make editing_language editable (was read-only)
- Preserve render_strategies, section_render_strategies, and translation on save
@amoghbanta amoghbanta merged commit a706408 into main Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant