Update ConfigEditor for render strategies + editing language#36
Merged
amoghbanta merged 1 commit intomainfrom Feb 13, 2026
Merged
Update ConfigEditor for render strategies + editing language#36amoghbanta merged 1 commit intomainfrom
amoghbanta merged 1 commit intomainfrom
Conversation
…ting_language The pipeline team replaced `web_rendering: StepConfig` with a render strategies system. Update ConfigEditor and StoryboardSettingsSheet to match: - Remove broken web_rendering.model and max_retries inputs - Add editable default_render_strategy input with placeholder from active config - Show read-only render strategy summary with type badges - Make editing_language editable (was read-only) - Preserve render_strategies, section_render_strategies, and translation on save
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web_rendering.modelandmax_retriesinputs (config key no longer exists after pipeline team's render strategies refactor)default_render_strategyinput with placeholder from active configtwo_column [template],llm [llm])editing_languageeditable (was read-only display)render_strategies,section_render_strategies,default_render_strategy, andtranslationon save in both ConfigEditor and StoryboardSettingsSheetTest plan
pnpm typecheckpassespnpm testpasses (330 tests)config.yamlgetsediting_languageand/ordefault_render_strategyif setrender_strategies,section_render_strategies,translationpreservedweb_rendering