Skip to content

Close section drawer on save and enable activities for activity sections#116

Merged
nicpottier merged 1 commit intomainfrom
nicpottier/close-drawer-on-save
Feb 24, 2026
Merged

Close section drawer on save and enable activities for activity sections#116
nicpottier merged 1 commit intomainfrom
nicpottier/close-drawer-on-save

Conversation

@nicpottier
Copy link
Contributor

Summary

  • Close section drawer panel immediately on save while waiting for re-render
  • Fix activities feature flag to detect activity section types (e.g., activity_multiple_choice, activity_matching) in addition to quiz pages
  • The packaging code was only checking for quiz-generation quizzes, missing activity sections from page-sectioning data

Test plan

  • Re-open the section editor, make changes, and save — verify drawer closes immediately
  • Generate a book with activity sections and open the preview — verify the submit button appears on activity sections
  • Test with both activity sections and quiz pages to ensure both are detected

When saving a section after editing, immediately close the drawer panel while waiting for re-render to give users visual feedback.

Fix the activities feature flag to enable when a book contains activity section types (like activity_multiple_choice) in addition to quiz pages. The packaging code was only checking for quizzes, missing activity sections entirely, which prevented the submit button from appearing in activity previews.
@nicpottier nicpottier merged commit 19e0dc8 into main Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant