fix: django-import-export unable to import #402
Conversation
| {% csrf_token %} | ||
|
|
||
| <p class="bg-blue-50 mb-8 text-blue-500 px-3 py-3 rounded-md text-sm dark:bg-blue-500/20 dark:border-blue-500/10"> | ||
| <div class="bg-blue-50 mb-8 text-blue-500 px-3 py-3 rounded-md text-sm dark:bg-blue-500/20 dark:border-blue-500/10"> |
There was a problem hiding this comment.
Since dl tags can't be inside p tag, switched to div to capture implemented classes
| self.fields["format"].widget.attrs["class"] = " ".join(SELECT_CLASSES) | ||
| resource_widget = self.fields["resource"].widget | ||
| if len(resource_widget.choices) > 0: | ||
| self.fields["resource"].widget = UnfoldAdminSelectWidget( |
There was a problem hiding this comment.
Replaced to using widgets here since they're already part of the unfold project and don't have to rewrite the same logic.
Not sure if there was a proper way of using this widget but this worked instead of just UnfoldAdminSelectWidget
|
Another suggestion for future is that the |
|
I didn't go thru each template from import_export but possibly needs some updates/restyling there also to match updates from their v4 |
|
First of all, thank you very much for high quality feedback. Based on your code, I created new PR fixing multiple issues. If you have time, would you mind to test my PR and provide another feedback? https://github.com/unfoldadmin/django-unfold/pull/404/files |
|
Closing in favor of #404. Thank you very much for valuable feedback. |
2 participants
Issue
Import action is broken per changes from #398
Resource was inferred as the file field but it's a different field on its own. Current issue can also be observed on the deployed unfoldadmin/formula
The actual file is never passed back to import-export since the expected input_file field is missing.
Changes
Reverting partial changes from #398 while cleaning up the formatting a touch to manage multiple resources
Single Resource View:
Multiple Resource View:
Tests
Tested locally with:
[email protected]
django@5
[email protected]
I didn't go too deep in the export action and how resources might play a part there since it was functional and not completely broken.