Skip to content

fix: use minifed version of jquery when settings.DEBUG is disabled #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasvinclav merged 2 commits into from
Nov 8, 2025
Merged

fix: use minifed version of jquery when settings.DEBUG is disabled #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23cd389
fix: use minifed version of jquery when settings.DEBUG is disabled
zaggino Nov 7, 2025
f642361
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/actions/action-form-example.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ This example demonstrates how to create an action that displays a custom form wh
# admin.py

from django import forms
from django.conf import settings
from django.contrib.auth.models import User
from django.http import HttpRequest, HttpResponse
from django.shortcuts import render
Expand All @@ -31,8 +32,9 @@ class SomeForm(forms.Form):

# Loads date widget required JS files
class Media:
extra = "" if settings.DEBUG else ".min"
js = [
"admin/js/vendor/jquery/jquery.js",
f"admin/js/vendor/jquery/jquery{extra}.js",
"admin/js/jquery.init.js",
"admin/js/calendar.js",
"admin/js/admin/DateTimeShortcuts.js",
Expand Down
7 changes: 5 additions & 2 deletions src/unfold/contrib/filters/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from django import forms
from django.conf import settings
from django.contrib.admin.options import HORIZONTAL
from django.contrib.admin.widgets import AutocompleteSelect, AutocompleteSelectMultiple
from django.db.models import Field as ModelField
Expand Down Expand Up @@ -67,8 +68,9 @@ def __init__(
)

class Media:
extra = "" if settings.DEBUG else ".min"
js = (
"admin/js/vendor/jquery/jquery.js",
f"admin/js/vendor/jquery/jquery{extra}.js",
"admin/js/vendor/select2/select2.full.js",
"admin/js/jquery.init.js",
"unfold/js/select2.init.js",
Expand Down Expand Up @@ -150,8 +152,9 @@ def __init__(
)

class Media:
extra = "" if settings.DEBUG else ".min"
js = (
"admin/js/vendor/jquery/jquery.js",
f"admin/js/vendor/jquery/jquery{extra}.js",
"admin/js/vendor/select2/select2.full.js",
"admin/js/jquery.init.js",
"unfold/js/select2.init.js",
Expand Down
7 changes: 5 additions & 2 deletions src/unfold/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from collections.abc import Callable
from typing import Any

from django.conf import settings
from django.contrib.admin.options import VERTICAL
from django.contrib.admin.sites import AdminSite
from django.contrib.admin.widgets import (
Expand Down Expand Up @@ -721,8 +722,9 @@ def __init__(self, attrs=None, choices=()):
super().__init__(attrs, choices)

class Media:
extra = "" if settings.DEBUG else ".min"
js = (
"admin/js/vendor/jquery/jquery.js",
f"admin/js/vendor/jquery/jquery{extra}.js",
"admin/js/vendor/select2/select2.full.js",
"admin/js/jquery.init.js",
"unfold/js/select2.init.js",
Expand Down Expand Up @@ -757,8 +759,9 @@ def __init__(self, attrs=None, choices=()):
super().__init__(attrs, choices)

class Media:
extra = "" if settings.DEBUG else ".min"
js = (
"admin/js/vendor/jquery/jquery.js",
f"admin/js/vendor/jquery/jquery{extra}.js",
"admin/js/vendor/select2/select2.full.js",
"admin/js/jquery.init.js",
"unfold/js/select2.init.js",
Expand Down