Skip to content

Conversation

@sezginacer
Copy link
Contributor

No description provided.

@lukasvinclav lukasvinclav merged commit fd859db into unfoldadmin:main Feb 5, 2025
7 checks passed
@lukasvinclav
Copy link
Contributor

awesome work. thanks

@dbartenstein
Copy link

dbartenstein commented Feb 25, 2025

@sezginacer
Unfortunately this fix does not work for Django 4.2 LTS, because there’s no ChangeList.filter_params.

Even Django main, still uses cl.params for compatibility reasons:
https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/search_form.html

@lukasvinclav Unfold admin supports all supported Django versions, I guess? Django 4.2 LTS (April 2026) still has more than one year to live: https://www.djangoproject.com/download/#supported-versions

Can we develop a template that works for all supported Django versions? Shall I create an issue for this?

@lukasvinclav
Copy link
Contributor

@dbartenstein would you mind to take a look on this problem in your team? Create a PR and I will review it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants