[UNDERTOW-1821] Path template matched parameters should keep order#983
Merged
fl4via merged 1 commit intoundertow-io:masterfrom Dec 3, 2020
Merged
Conversation
Contributor
Author
|
@stuartwdouglas what do you think? |
452ff65 to
843ecc3
Compare
843ecc3 to
d6ee3b2
Compare
fl4via
approved these changes
Dec 3, 2020
Member
|
@seregamorph we are approving this change. The advantage of keeping parameters in order outweights the added overhead, specially because hte matcher's map is small and is not used every where in the code. |
Contributor
Author
|
Thanks @fl4via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/UNDERTOW-1821
Replace

HashMaptoLinkedHashMapinPathTemplateMatcher. Motivation: ordered matched paths look more natural e.g. in debugging:Also in my case I needed to write a simple custom matcher: not Map (expected) equals Map (actual), but a List of matched values (cannot use
Set, because values can be repeated).Reference implementation: spring-core
org.springframework.util.AntPathMatcherkeeps original order:Cons: in theory, updated impl will take more nanoseconds in runtime and more nanobytes in memory, but I believe if there was an intention to micro-optimise it, these should be a custom Map implementation (like Netty
HttpHeaders)