[UNDERTOW-2603] Fix double cookie on quoted value#1790
Merged
Conversation
baranowb
added
bug fix
Contributor
Author
|
Just so CI has a go. |
baranowb
commented
Sep 11, 2025
baranowb
force-pushed
the
UNDERTOW-2603
branch
from
3e2bca5 to
449252d
Compare
baranowb
commented
Oct 29, 2025
| } | ||
|
|
||
| static Map<String, Cookie> parseRequestCookies(int maxCookies, boolean allowEqualInValue, List<String> cookies, boolean commaIsSeperator, boolean allowHttpSepartorsV0) { | ||
| static Map<String, Cookie> parseRequestCookies(int maxCookies, boolean allowEqualInValue, List<String> cookies, boolean commaIsSeperator, boolean allowHttpSepartorsV0, boolean rfc6265ParsingDisabled){ |
Contributor
Author
There was a problem hiding this comment.
rfc6265ParsingDisabled - this is negative, but it seems it in line with default definitions.
fl4via
approved these changes
Jan 12, 2026
fl4via
added
next release
Member
|
@baranowb we will need to work in the conflicts, and unfortunately this will require some rework of the parsing algorithm change contained in this PR |
Contributor
Author
|
Yeah, sadly I knew it would be the case, might be that this wont be relevant now. due to other changes, still trying to verify if this is still issue or not. |
Contributor
Author
|
Yeah, the bug is still there, just mitigated by other code. |
baranowb
force-pushed
the
UNDERTOW-2603
branch
from
449252d to
be5cf82
Compare
fl4via
added
waiting CI check
fl4via
added
next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2603
2.4.x PR: #1928
2.3.x PR: #1935
2.2.x PR: todo