refactor: target ES2020 to drop tslib dependency#240
Conversation
🦋 Changeset detectedLatest commit: d8435b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe changes update the TypeScript compilation target from ES2015 to ES2020 in the configuration file and remove the Changes
Assessment against linked issues
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (20)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request updates the target environment to ES2020 in the TypeScript configuration, reflecting a shift towards more modern JavaScript features. It also includes various dependency updates in Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package dependencies by removing tslib and bumping several dev dependencies to their newest patch versions.
- Remove
tslibfrom runtime dependencies. - Upgrade
eslint,ts-jest, andtsdownin devDependencies.
Comments suppressed due to low confidence (1)
package.json:64
- Removing tslib may break runtime helper imports; verify that
importHelpersis disabled in your tsconfig or re-add tslib if needed.
"tslib": "^2.8.1"
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
JounQin
changed the title
tslib dependency
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to d480f1f in 49 seconds. Click for details.
- Reviewed
35lines of code in1files - Skipped
2files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:62
- Draft comment:
Removed 'tslib' dependency as expected for ES2020 target. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, stating that a dependency was removed due to a target change. It doesn't provide any actionable feedback or suggestions for improvement.
2. package.json:81
- Draft comment:
Bumped eslint from ^9.26.0 to ^9.27.0. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. package.json:94
- Draft comment:
Updated ts-jest from ^29.3.2 to ^29.3.4. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. package.json:98
- Draft comment:
Updated tsdown from ^0.11.9 to ^0.11.10. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_nVe0h0u7yINmbeAW
You can customize 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 95.80% 95.79% -0.02%
==========================================
Files 4 4
Lines 334 333 -1
Branches 155 154 -1
==========================================
- Hits 320 319 -1
+ Misses 14 11 -3
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📊 Package size report -0.9%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
size-limit report 📦
|
commit: |
|
close #239
Important
Update target ECMAScript version to ES2020 and modify dependencies in
package.json.tslibfrom dependencies inpackage.json.eslintto^9.27.0.ts-jestto^29.3.4.tsdownto^0.11.10.This description was created by
for d480f1f. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit