Skip to content

Conversation

@ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Mar 26, 2021

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #571 (f4344df) into master (99c5eb0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   46.05%   46.09%   +0.03%     
==========================================
  Files          67       67              
  Lines        1598     1599       +1     
  Branches      435      436       +1     
==========================================
+ Hits          736      737       +1     
  Misses        861      861              
  Partials        1        1              
Impacted Files Coverage Δ
packages/plugin-esbuild/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c5eb0...f4344df. Read the comment docs.

@ycjcl868 ycjcl868 requested a review from sorrycc March 26, 2021 06:53
@sorrycc
Copy link
Member

sorrycc commented Mar 26, 2021

  1. target 接收字符串或数组
  2. https://umijs.org/plugins/plugin-esbuild 文档补充下

@ycjcl868 ycjcl868 changed the title fix(esbuild): minify using es5 fix(esbuild): minify exposes target config for es5 projects Mar 26, 2021
@ycjcl868
Copy link
Contributor Author

  1. target 接收字符串或数组
  2. https://umijs.org/plugins/plugin-esbuild 文档补充下

ok

@sorrycc sorrycc merged commit cb93b3a into master Mar 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-esbuild-minify branch March 26, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

esbuild minifySyntax shouldn't convert string with \n into template literals in target es6

3 participants