Fixes race condition in PublishedSnapshotService and more...#5924
Merged
warrenbuckley merged 1 commit intov8/8.1from Jul 23, 2019
Merged
Fixes race condition in PublishedSnapshotService and more...#5924warrenbuckley merged 1 commit intov8/8.1from
warrenbuckley merged 1 commit intov8/8.1from
Conversation
Contributor
|
Code looks fine, just remember we need to come back round to those TODOs @Shazwazza |
Contributor
|
Tested ZIP build and all works fine for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5035
There's an issue in some rare cases where if multiple appdomains startup at once that the nucache files can get locked. This is mostly prevalent on Azure web apps when using the slot swap functionality.
Other things/issues: